Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the copy on site provision notification for dev sites. #94562

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

andregardi
Copy link
Contributor

@andregardi andregardi commented Sep 13, 2024

Closes https://github.com/Automattic/dotcom-forge/issues/9044

Proposed Changes

When a site is created on A4A, the user is presented with the following notification:

Your WordPress.com site is ready!
{site-address} is now ready. Get started by configuring your new site. It may take a few minutes for it to show up in the site list below.

Since the site is already configured, because of site configuration modal, we are removing Get started by configuring your new site. text. Even for non development sites.

Specifically for development sites, we are adding a new complement to the message to include Before the site launches, you will be able to find it under Development.

Testing Instructions

Apply this branch locally.
Because there are a different entry points I would suggest to create a development site from 2 different places.

  • From home (using the header menu)
  • From the sites page (also using the header menu)

Each time you create a dev site you should message should look like this:
image

Now create a non development site, from the Needs setup page. It should not contain the Get started by configuring your new site. text on the message body.
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/a4a-update-site-ready-copy on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Sep 14, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~184 bytes added 📈 [gzipped])

name                           parsed_size           gzip_size
a8c-for-agencies-sites             +1357 B  (+0.1%)     +305 B  (+0.1%)
a8c-for-agencies-overview           +736 B  (+0.1%)     +123 B  (+0.0%)
jetpack-cloud-agency-sites-v2        +79 B  (+0.0%)      +10 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@andregardi andregardi requested a review from a team September 14, 2024 00:21
@andregardi andregardi self-assigned this Sep 14, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 14, 2024
@andregardi andregardi force-pushed the update/a4a-update-site-ready-copy branch from afbda35 to 17b5b5c Compare September 16, 2024 15:55
Copy link
Contributor

@yansern yansern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both flows and works.

useSiteCreatedCallback and isRecentlyCreatedSiteDevelopment is handy, thanks.

@andregardi andregardi merged commit 2cf3125 into trunk Sep 17, 2024
11 checks passed
@andregardi andregardi deleted the update/a4a-update-site-ready-copy branch September 17, 2024 16:47
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 17, 2024
@a8ci18n
Copy link

a8ci18n commented Sep 17, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16838070

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @andregardi for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 23, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants