-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the copy on site provision notification for dev sites. #94562
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~184 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
afbda35
to
17b5b5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both flows and works.
useSiteCreatedCallback
and isRecentlyCreatedSiteDevelopment
is handy, thanks.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16838070 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @andregardi for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Closes https://github.com/Automattic/dotcom-forge/issues/9044
Proposed Changes
When a site is created on A4A, the user is presented with the following notification:
Since the site is already configured, because of site configuration modal, we are removing
Get started by configuring your new site.
text. Even for non development sites.Specifically for development sites, we are adding a new complement to the message to include
Before the site launches, you will be able to find it under Development.
Testing Instructions
Apply this branch locally.
Because there are a different entry points I would suggest to create a development site from 2 different places.
Each time you create a dev site you should message should look like this:
Now create a non development site, from the Needs setup page. It should not contain the
Get started by configuring your new site.
text on the message body.Pre-merge Checklist