Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper: Onboarding flow update tracks events #94560

Merged
merged 12 commits into from
Sep 19, 2024

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Sep 13, 2024

Fixes: #94417
Fixes: #94420
Fixes: #94419
Fixes: #94418

Proposed Changes

Why are these changes being made?

  • Align with /start and be able to analyze important user data

Testing Instructions

  • Checkout branch or use live link
  • Navigate to /setup/onboarding. Go through the flow and verify the correct events are recorded with necessary props.
  • Compare to /start on production to see the latest state then compare against /start on local to ensure both are returning the same events and props.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@agrullon95 agrullon95 changed the title Update/stepper onboarding events v1 Stepper: Onboarding flow update tracks events Sep 13, 2024
@agrullon95 agrullon95 self-assigned this Sep 13, 2024
@agrullon95 agrullon95 requested a review from a team September 13, 2024 20:50
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~90 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +242 B  (+0.0%)      +90 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

…ains and unified-plans steps for improved tracking
@agrullon95 agrullon95 marked this pull request as ready for review September 16, 2024 16:54
@agrullon95 agrullon95 requested a review from a team as a code owner September 16, 2024 16:54
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Domains 🔴

image

I see the calypso_signup_actions_submit_step event being fired twice. The second time with [object Object], but that is identical to what happens in prod.

Plans 🔴

image

The event is fired three times.

calypso_signup_plan_select 🟢

image

calypso_page_view 🟢

@escapemanuele escapemanuele requested a review from a team as a code owner September 18, 2024 14:30
@escapemanuele escapemanuele requested a review from a team September 18, 2024 20:51
@renancarvalho
Copy link
Contributor

Checking on live link

For #94417, the domain_item is empty
For #94420 cart items still wrong
image
#94419 is good ✅
#94418 is good ✅

@escapemanuele
Copy link
Contributor

Thank you @renancarvalho!

  • Domains: The value is empty when you select the free domain, so that should be fine
  • Plans: Yes, we changed to reflect how it is in /start

@escapemanuele escapemanuele self-requested a review September 19, 2024 09:17
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stepper-onboarding-events-v1 on your sandbox.

@escapemanuele
Copy link
Contributor

Opened #94708 as a follow-up

@escapemanuele escapemanuele merged commit 1f23372 into trunk Sep 19, 2024
11 checks passed
@escapemanuele escapemanuele deleted the update/stepper-onboarding-events-v1 branch September 19, 2024 12:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment