-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stepper: Onboarding flow update tracks events #94560
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~90 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
…ains and unified-plans steps for improved tracking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @renancarvalho!
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Opened #94708 as a follow-up |
Fixes: #94417
Fixes: #94420
Fixes: #94419
Fixes: #94418
Proposed Changes
calypso_signup_actions_submit_step
records the same props as Classic/Start #94417 and Stepper: Plans page - ensurecalypso_signup_actions_submit_step
Tracks event records the correct props #94420)calypso_signup_plan_select
when Plan is selected (product_slug
andfrom_section
)flow
prop tocalypso_page_view
eventWhy are these changes being made?
Testing Instructions
/setup/onboarding
. Go through the flow and verify the correct events are recorded with necessary props./start
on production to see the latest state then compare against/start
on local to ensure both are returning the same events and props.Pre-merge Checklist