Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A Dev Site Actions: Enhance style for the dev site delete confirmation dialogue. #94555

Merged

Conversation

mashikag
Copy link
Contributor

@mashikag mashikag commented Sep 13, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/9133

Proposed Changes

  • Set max-width of the dialogue to 800px.
  • Unset the margin-bottom of the dialogue's fieldset element.
  • Display the domain to be typed-in for confirmation in red (same shade as the "Delete" button).

Why are these changes being made?

  • In order to improve the UX.

Testing Instructions

  • Create a free development site if you do not have one already.
  • Go to http://agencies.localhost:3000/sites
  • Click on the "Site actions" elipsis of a dev site row.
  • In the "Site actions" dropdown select "Delete site".
  • You should see the confirmation dialogue with the enhanced styles applied.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?
Before After

@mashikag mashikag requested a review from a team September 13, 2024 16:21
@mashikag mashikag self-assigned this Sep 13, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@mashikag
Copy link
Contributor Author

Hey @matt-west and @nuriapenya! 👋
Could I get some quick feedback from you on the delete development site confirmation dialogue.
The above PR is suggesting some minor styling enhancements to the current A4A "Delete site" confirmation dialogue.

Is there something you would change about the styling, or perhaps could you suggest some additional changes?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/a4a-enhance-dev-site-delete-confirm-dialogue-style on your sandbox.

@mashikag mashikag merged commit 16f76e8 into trunk Sep 16, 2024
14 checks passed
@mashikag mashikag deleted the update/a4a-enhance-dev-site-delete-confirm-dialogue-style branch September 16, 2024 11:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants