Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Profiler: add email subscription tracks event #94549

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

gcsecsey
Copy link
Contributor

@gcsecsey gcsecsey commented Sep 13, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/8811

Proposed Changes

  • add email subscription tracks event
  • add email unsubscription tracks event

Why are these changes being made?

p1726234242762659-slack-C02JPCHEKDY

Testing Instructions

  • Open Chrome devtools and in the Console tab, paste this command to enable analytics logging:
localStorage.setItem( 'debug', 'calypso:analytics*' );
  • On the Console tab, set the verbose logging level, and add the calypso_performance_profiler filter:
    CleanShot 2024-09-10 at 14 49 54@2x
  • Start a new test by adding the site URL as a parameter, eg.:
/speed-test-tool?url=google.com

or go to a report page, eg.:

/speed-test-tool?url=https%3A%2F%2Fwordpress.com%2F&hash=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpZCI6NzA1N30.7KXaBL1qcm0y0GqvM8ymJ0pbST9ls6P09_hri8EaKSI
  • Subscribe to the weekly reports for the test
  • On the /weekly-report page, check in the logs that the tracks event is fired correctly once the API response is loaded

CleanShot 2024-09-13 at 15 38 04@2x

  • Copy the URL params to the /speed-test-tool/weekly-report/unsubscribe page
  • check in the logs that the tracks event is fired correctly once the API response is loaded

@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~27 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
performance-profiler       +246 B  (+0.1%)      +27 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/performance-profiler-report-tracks on your sandbox.

@gcsecsey gcsecsey merged commit 7180150 into trunk Sep 13, 2024
12 checks passed
@gcsecsey gcsecsey deleted the add/performance-profiler-report-tracks branch September 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants