Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature flag and ship Woo database sync from staging sites #94518

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

andregardi
Copy link
Contributor

@andregardi andregardi commented Sep 13, 2024

Proposed Changes

Review it but do not merge this

We are removing the staging-site-sync-woo feature flag and releasing the Woo SQL Sync to all users.

Testing Instructions

The new messaging should be displayed when WooCommerce plugin is active on the site.

Before creating a staging site

The new Preview and troubleshoot changes before updating your production site message should be visible only when WooCommerce is active.

WooCommerce active WooCommerce deactivated
image image

Toggling Site database (SQL)

If WooCommerce is not active on the site, you should be able to Sync SQL without any warning.
If WooCommerce is active, you should see the new messaging. If user toggle to sync SQL, the Synchronize button should be disabled until the confirmation checkbox is checked.

WooCommerce active WooCommerce deactivated
image image

Confirmation modal

After clicking on Synchronize button user should see the final confirmation modal.

If WooCommerce is active, you should see the new warning box.
If WooCommerce is not active, the warning box should not be present.

Also test that if the SQL option is not toggled, the new warning box should not be present even if WooCommerce is active.

WooCommerce active WooCommerce deactivated WooCommerce active BUT SQL is not toggled
image image image

Test syncing

Complete the sync with WooCommerce toggling the SQL option.
It may take some time, but syncing data from staging to production should work.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/launch-woo-sync on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~77 bytes removed 📉 [gzipped])

name          parsed_size           gzip_size
staging-site       -336 B  (-0.0%)      -77 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@andregardi andregardi requested a review from a team September 13, 2024 01:25
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2024
@andregardi andregardi self-assigned this Sep 13, 2024
@andregardi andregardi force-pushed the update/launch-woo-sync branch from 7f96058 to f32257f Compare September 16, 2024 15:58
@andregardi andregardi merged commit 7c10369 into trunk Sep 16, 2024
11 checks passed
@andregardi andregardi deleted the update/launch-woo-sync branch September 16, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants