Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins Marketplace: Update plugin guide links and copy #94294

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Sep 6, 2024

Related to #93587

Proposed Changes

Before After
Screenshot 2024-09-06 at 9 37 34 AM Screenshot 2024-09-06 at 9 37 06 AM

Why are these changes being made?

  • Replace outdated content with evergreen content

Testing Instructions

  • Use Calypso live and go to /plugins
  • Ensure the copy looks good and the links are correct

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/plugin-guides on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~7 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
plugins                                -62 B  (-0.0%)       -7 B  (-0.0%)
jetpack-cloud-plugin-management        -62 B  (-0.0%)       -7 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DustyReagan DustyReagan self-assigned this Sep 6, 2024
@DustyReagan DustyReagan marked this pull request as ready for review September 6, 2024 14:46
@DustyReagan DustyReagan requested a review from a team September 6, 2024 14:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 6, 2024
@DustyReagan DustyReagan changed the title Update plugin guide links and copy Plugins Marketplace: Update plugin guide links and copy Sep 6, 2024
Copy link
Contributor

@eoigal eoigal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM 👍

@DustyReagan DustyReagan added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Sep 6, 2024
@a8ci18n
Copy link

a8ci18n commented Sep 6, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16656492

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @DustyReagan for including a screenshot in the description! This is really helpful for our translators.

@DustyReagan DustyReagan merged commit fb6c778 into trunk Sep 9, 2024
19 of 20 checks passed
@DustyReagan DustyReagan deleted the update/plugin-guides branch September 9, 2024 16:31
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Sep 9, 2024
@a8ci18n
Copy link

a8ci18n commented Sep 9, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins Marketplace: The guides in the "Get started with plugins" section are outdated
4 participants