-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stepper: Apply extended props to calypso_page_view
#94229
Stepper: Apply extended props to calypso_page_view
#94229
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~266 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~316 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~228 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I'm going to close this one. It's too far into conflicts zone. We can introduce it later if there's ever a need. In any case, ignoring the dependency also makes this a lot less tempting to push through. |
Part of addressing #94108
Proposed Changes
STEPPER_TRACKS_EVENT_PAGE_VIEW
calypso_signup_page_view
eventDO NOT MERGE - depended on ongoing discussions in #94175 (similar/same problem)
Why are these changes being made?
Testing Instructions
/setup/onboarding
and/setup/newsletter
calypso_signup_page_view
when walking through steps in Stepper works like beforePre-merge Checklist