Stepper: Update tests to reflect calypso_signup_start event triggered N times, not 1

[chriskmnds]

Related to #94175

Proposed Changes

Updates the test suite for useSignUpStartTracking to presumably "correct" the tests.

This is not meant for shipping, but rather to highlight a false positive in the test suite (one of the most important tests I guess). Only meant to accompany/verify #94175

Why are these changes being made?

To demonstrate a false positive test. See #94175

Testing Instructions

• tests should pass, even though they shouldn't
• yarn test-client client/landing/stepper/declarative-flow/internals/hooks/use-sign-up-start-tracking/test/index.tsx

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-118254

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-118254&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-118254&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stepper-tracking-signup-start-multi on your sandbox.

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[gabrielcaires]

@chriskmnds I am a bit confused. Do we want to have calypso_signup_start calls? I read the issue and It seems we need to fix instead of update the tests 🤔

[chriskmnds]

@chriskmnds I am a bit confused. Do we want to have calypso_signup_start calls? I read the issue and It seems we need to fix instead of update the tests 🤔

@gabrielcaires The tests are meant to verify and call out the false positive (they are not fixing obviously)! Sorry for the confusion -I'm only doing this to accompany #94175

I guess once you invalidate/fail these two tests, then we have fixed the issue :-)