Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: update editor checkout style #94117

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

eoigal
Copy link
Contributor

@eoigal eoigal commented Sep 2, 2024

Fixes #93898

Removes empty space above Checkout title in editor checkout modal.

Before

Screenshot 2024-09-03 at 10 29 48

After

Screenshot 2024-09-03 at 10 44 13

Demo (comparing positioning in modal vs regular checkout)

Screen.Recording.2024-09-03.at.10.43.31.mov

Proposed Changes

  • Updates styles to use a different margin-top when viewing checkout in editor checkout modal

Why are these changes being made?

  • Logical flows

Testing Instructions

  • Open a post on a simple test site
  • Go to Jetpack SEO upgrade
  • It should open the editor checkout modal
  • Confirm it looks ok

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@eoigal eoigal requested a review from a team as a code owner September 2, 2024 20:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 2, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/editor-checkout-style on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Sep 2, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~33 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout       +163 B  (+0.0%)      +33 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~33 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal            +163 B  (+0.0%)      +33 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal       +163 B  (+0.0%)      +33 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections here.

Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good!

@eoigal eoigal merged commit 244c93d into trunk Sep 3, 2024
12 checks passed
@eoigal eoigal deleted the update/editor-checkout-style branch September 3, 2024 14:50
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkout: Header has too much white space
4 participants