-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iframe error when accessing Add new Page on post command palette #94114
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
@epeicher I've extracted the duplicated code into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described 👌
Thanks @xavier-lc , great refactoring, much more generic |
Related to #93979
Proposed Changes
Add new post
andAdd new page
to thecalypsoify-iframe
to avoid iframe errorsAdd new page
andAdd new post
commands in the Command paletteWhy are these changes being made?
Testing Instructions
cd apps/wpcom-block-editor/ && yarn dev --sync
widgets.wp.com
http://calypso.localhost:3000/post/<your simple site>
, e.g.http://calypso.localhost:3000/post/mytestsimplesite.wordpress.com
Cmd+K
Add new page
orAdd new post
Pre-merge Checklist