Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight themes in sidebar when viewing individual theme #94028

Merged

Conversation

allilevine
Copy link
Member

@allilevine allilevine commented Aug 29, 2024

Related to #92645

Proposed Changes

  • Highlight the "Themes" menu item in the sidebar when viewing individual theme pages, at both the global and site levels.
Before After
Screen Shot 2024-08-29 at 11 56 28 AM Screen Shot 2024-08-29 at 11 56 15 AM
Screen Shot 2024-08-29 at 11 55 43 AM Screen Shot 2024-08-29 at 2 08 12 PM

Why are these changes being made?

  • To keep the interface consistent between the themes showcase and clicking a theme.

Testing Instructions

  • Go to /sites and click Themes.
  • Check that Themes is highlighted or has a selected class.
  • Click on an individual theme.
  • Check that Themes is still highlighted.
  • Go to /home and click Appearance > Themes.
  • Check that Appearance > Themes is open and highlighted.
  • Click on an individual theme.
  • Check that Themes is still highlighted.
  • Check that there are no regressions on logged-out /themes.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/highlight-themes-in-sidebar-when-viewing-theme on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~204 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
woocommerce-installation                  +31 B  (+0.0%)      +12 B  (+0.0%)
woocommerce                               +31 B  (+0.0%)      +12 B  (+0.0%)
themes                                    +31 B  (+0.0%)      +12 B  (+0.0%)
theme                                     +31 B  (+0.0%)      +12 B  (+0.0%)
subscribers                               +31 B  (+0.0%)      +12 B  (+0.0%)
stats                                     +31 B  (+0.0%)      +12 B  (+0.0%)
staging-site                              +31 B  (+0.0%)      +13 B  (+0.0%)
sites-dashboard                           +31 B  (+0.0%)      +13 B  (+0.0%)
site-purchases                            +31 B  (+0.0%)      +11 B  (+0.0%)
site-monitoring                           +31 B  (+0.0%)      +13 B  (+0.0%)
site-logs                                 +31 B  (+0.0%)      +13 B  (+0.0%)
site-blocks                               +31 B  (+0.0%)      +12 B  (+0.0%)
settings-writing                          +31 B  (+0.0%)      +12 B  (+0.0%)
settings-security                         +31 B  (+0.0%)      +12 B  (+0.0%)
settings-reading                          +31 B  (+0.0%)      +12 B  (+0.0%)
settings-podcast                          +31 B  (+0.0%)      +12 B  (+0.0%)
settings-performance                      +31 B  (+0.0%)      +12 B  (+0.0%)
settings-newsletter                       +31 B  (+0.0%)      +12 B  (+0.0%)
settings-jetpack                          +31 B  (+0.0%)      +12 B  (+0.0%)
settings-discussion                       +31 B  (+0.0%)      +12 B  (+0.0%)
settings                                  +31 B  (+0.0%)      +11 B  (+0.0%)
security                                  +31 B  (+0.0%)      +12 B  (+0.0%)
scan                                      +31 B  (+0.0%)      +12 B  (+0.0%)
purchases                                 +31 B  (+0.0%)      +11 B  (+0.0%)
promote-post-i2                           +31 B  (+0.0%)      +12 B  (+0.0%)
privacy                                   +31 B  (+0.0%)      +12 B  (+0.0%)
preview                                   +31 B  (+0.0%)      +12 B  (+0.0%)
posts-custom                              +31 B  (+0.0%)      +12 B  (+0.0%)
posts                                     +31 B  (+0.0%)      +12 B  (+0.0%)
plugins                                   +31 B  (+0.0%)      +11 B  (+0.0%)
plans                                     +31 B  (+0.0%)      +12 B  (+0.0%)
people                                    +31 B  (+0.0%)      +12 B  (+0.0%)
pages                                     +31 B  (+0.0%)      +12 B  (+0.0%)
notification-settings                     +31 B  (+0.0%)      +12 B  (+0.0%)
migrate                                   +31 B  (+0.0%)      +12 B  (+0.0%)
media                                     +31 B  (+0.0%)      +13 B  (+0.0%)
me                                        +31 B  (+0.0%)      +12 B  (+0.0%)
marketplace                               +31 B  (+0.0%)      +16 B  (+0.0%)
marketing                                 +31 B  (+0.0%)      +12 B  (+0.0%)
jetpack-social                            +31 B  (+0.0%)      +12 B  (+0.0%)
jetpack-search                            +31 B  (+0.0%)      +12 B  (+0.0%)
jetpack-connect                           +31 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-settings                    +31 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-pricing                     +31 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-plugin-management           +31 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-partner-portal              +31 B  (+0.0%)      +13 B  (+0.0%)
jetpack-cloud-overview                    +31 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-features-comparison         +31 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-agency-sites-v2             +31 B  (+0.0%)      +13 B  (+0.0%)
jetpack-cloud                             +31 B  (+0.0%)      +12 B  (+0.0%)
import                                    +31 B  (+0.0%)      +12 B  (+0.0%)
hosting-features                          +31 B  (+0.0%)      +13 B  (+0.0%)
hosting                                   +31 B  (+0.0%)      +13 B  (+0.0%)
home                                      +31 B  (+0.0%)      +12 B  (+0.0%)
help                                      +31 B  (+0.0%)      +12 B  (+0.0%)
gutenberg-editor                          +31 B  (+0.0%)      +12 B  (+0.0%)
google-my-business                        +31 B  (+0.0%)      +12 B  (+0.0%)
github-deployments                        +31 B  (+0.0%)      +13 B  (+0.0%)
export                                    +31 B  (+0.0%)      +12 B  (+0.0%)
email                                     +31 B  (+0.0%)      +12 B  (+0.0%)
earn                                      +31 B  (+0.0%)      +12 B  (+0.0%)
domains                                   +31 B  (+0.0%)      +11 B  (+0.0%)
developer                                 +31 B  (+0.0%)      +12 B  (+0.0%)
customize                                 +31 B  (+0.0%)      +12 B  (+0.0%)
concierge                                 +31 B  (+0.0%)      +12 B  (+0.0%)
comments                                  +31 B  (+0.0%)      +12 B  (+0.0%)
checkout                                  +31 B  (+0.0%)      +16 B  (+0.0%)
backup                                    +31 B  (+0.0%)      +12 B  (+0.0%)
add-ons                                   +31 B  (+0.0%)      +12 B  (+0.0%)
activity                                  +31 B  (+0.0%)      +12 B  (+0.0%)
account-close                             +31 B  (+0.0%)      +12 B  (+0.0%)
account                                   +31 B  (+0.0%)      +26 B  (+0.0%)
a8c-for-agencies-team                     +31 B  (+0.0%)      +13 B  (+0.0%)
a8c-for-agencies-sites                    +31 B  (+0.0%)      +13 B  (+0.0%)
a8c-for-agencies-settings                 +31 B  (+0.0%)      +13 B  (+0.0%)
a8c-for-agencies-referrals                +31 B  (+0.0%)      +13 B  (+0.0%)
a8c-for-agencies-purchases                +31 B  (+0.0%)      +14 B  (+0.0%)
a8c-for-agencies-plugins                  +31 B  (+0.0%)      +13 B  (+0.0%)
a8c-for-agencies-partner-directory        +31 B  (+0.0%)      +12 B  (+0.0%)
a8c-for-agencies-overview                 +31 B  (+0.0%)      +13 B  (+0.0%)
a8c-for-agencies-migrations               +31 B  (+0.0%)      +13 B  (+0.0%)
a8c-for-agencies-marketplace              +31 B  (+0.0%)      +13 B  (+0.0%)
a8c-for-agencies-client                   +31 B  (+0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@allilevine allilevine marked this pull request as ready for review August 29, 2024 15:59
@allilevine allilevine requested a review from a team August 29, 2024 15:59
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 29, 2024
@allilevine allilevine self-assigned this Aug 29, 2024
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 👍

@allilevine allilevine merged commit d769212 into trunk Aug 29, 2024
18 checks passed
@allilevine allilevine deleted the add/highlight-themes-in-sidebar-when-viewing-theme branch August 29, 2024 18:34
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants