Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iframe error when accessing patterns on post command palette #93787

Conversation

xavier-lc
Copy link
Contributor

@xavier-lc xavier-lc commented Aug 21, 2024

Related to #92634

Proposed Changes

  • Handle the user's interaction with the Patterns command on the command palette through the iframe bridge, so the destination page can be opened as expected instead of being blocked because of it being inside an iframe.

Why are these changes being made?

  • Currently, clicking on the Patterns command on the command leaves the users with an error page and this message on the console: Refused to display 'https://xavilc12.wordpress.com/' in a frame because it set 'X-Frame-Options' to 'sameorigin'.

image

Testing Instructions

  • Checkout this branch locally on the wp-calypso folder
  • Go to the apps/wpcom-block-editor folder inside wp-calypso
  • Run yarn dev --sync, this will add the necessary changes to your sandbox
  • Sandbox widgets.wp.com
  • Open the calypso live preview
  • Go to /post
  • Select a site with the default interface (otherwise, you'll be redirected to wp-admin and won't use the iframe editor)
  • Click on the command palette, and then type Patterns and click on it
  • Check that you are redirected to the patterns page:

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Aug 21, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~36 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
gutenberg-editor       +149 B  (+0.0%)      +36 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/iframe-error-when-accessing-patterns-on-post-command-palette on your sandbox.

@xavier-lc xavier-lc self-assigned this Aug 22, 2024
@xavier-lc xavier-lc added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Aug 22, 2024
@xavier-lc xavier-lc changed the title [WiP] Fix iframe error when accessing patterns on post command palette Fix iframe error when accessing patterns on post command palette Aug 22, 2024
Copy link
Contributor

@TimBroddin TimBroddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 🎈
Works as intended & code checks out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groundskeeping Issues handled through Dotcom Groundskeeping rotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants