-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix iframe error when accessing patterns on post command palette #93787
Fix iframe error when accessing patterns on post command palette #93787
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~36 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! 🎈
Works as intended & code checks out!
Related to #92634
Proposed Changes
Patterns
command on the command palette through the iframe bridge, so the destination page can be opened as expected instead of being blocked because of it being inside aniframe
.Why are these changes being made?
Patterns
command on the command leaves the users with an error page and this message on the console:Refused to display 'https://xavilc12.wordpress.com/' in a frame because it set 'X-Frame-Options' to 'sameorigin'.
Testing Instructions
wp-calypso
folderapps/wpcom-block-editor
folder insidewp-calypso
yarn dev --sync
, this will add the necessary changes to your sandboxwidgets.wp.com
/post
Patterns
and click on itPre-merge Checklist