-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout Plan Upsell: Improve UX by adding a "Plan" column heading #92727
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~131 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~131 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that Plan is the column heading, the entry Two years isn't correct. It should be Two year.
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Thanks for the review @donnapep!
Funny, because this was the exact thing I was trying to avoid (p1721143498561319/1720709664.946129-slack-C02NWDZBL0H). 😅 But I see your point. I've updated the plan labels (and the screenshots) to use the compound adjective form, i.e. "Two-year". Let me know if this makes more sense or if I should stick to "Two year" instead. I've also changed the "Plan" / "(Two-year) Cost" columns to be always visible. They were showing only for an intro offer before. cc @bohdankit07 for visibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I am misreading this, but to me it looks like the monthly billing term is incorrect:
If we're using this sidebar callout to compare what a plan billed monthly would cost over 24 months versus a plan billed every two-years then we would need to show:
Billing interval | Cost over two years |
---|---|
Monthly | $216 |
Biennially |
Especially since the context of the component is "hey, if you consider sticking with us for two years, you'll end up saving a lot of money compared to being billed each month over that same time period."
But currently this component doesn't work like that. Instead we say "here is the cost of a One Month plan ($9) and here is the cost of a Two-year plan ($216) and here is the cost of that Two-year plan discounted ($78).
To me, this is more confusing since it is very easy to not understand where the $216 figure comes from and to just assume that it is the cost of plan when billed in two-year increments.
I know we wanted to stop using terms like 'biennially, triennially etc' in favor of less wordy alternatives, but saying 'One Month Plan' and 'Two-year Plan' is different than saying 'Plan billed monthly' and 'Plan billed every two years'.
<div className="checkout-sidebar-plan-upsell__plan-grid-cell"> | ||
{ currentVariant.variantLabel } | ||
<strong>{ __( 'Plan' ) }</strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we want to consider something that indicates it is the billing term, or, 'plan length'?
"Plan" is usually used to describe the feature set of the subscription whereas billing term is often used to indicate how many units of time until expiration of the plan. So in this case, 'billing term' or some variant of that would likely be more accurate as a header.
<strong>{ __( 'Plan' ) }</strong> | ||
</div> | ||
<div className="checkout-sidebar-plan-upsell__plan-grid-cell"> | ||
<strong>{ isComparisonWithIntroOffer ? __( 'Two-year cost' ) : __( 'Cost' ) }</strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason 'Two-year cost' doesn't sit well with me as a header. Maybe it is because I interpret this in the same way as the second line item where it also says 'Two-year'.
But I am not sure what alternative would fit better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure why there is a differentiation between annual -> biennial
and monthly -> biennial
here. Wouldn't the second line still be the monthly cost over two years compared to the two-year billing term of the plan?
Hey, thanks for the review @jjchrisdiehl!
I absolutely agree with you - the wording and the calculations are confusing. I would be happy to change those but I'm missing context and the idea of this PR was to make a small improvement. Maybe it would be best to involve @bohdankit07 in this decision. @bohdankit07, do you think we should update the calculations and the copy as @jjchrisdiehl is suggesting? |
@m1r0 Could we nudge this PR along? We can go with what we have for now. I'll try to give it another review soon, but if not, please seek approval from someone else. 🙇🏻♀️ |
Thanks for nudging me to nudge the PR, Donna. 😄 🙇 @bohdankit07, can you provide some guidance? Do you think these changes make an improvement? |
Closing because there is no consensus on this one. |
@m1r0 I apologize for missing this one! It has just resurfaced in my email notifications. We should ship it as it clarifies the calculations. Thank you! |
Adding it to my to-do list. Thanks Bohdan! |
1533c99
to
2560238
Compare
The PR was rebased. It's ready for review. |
Related to p1720709664946129-slack-C02NWDZBL0H and p1721070418619219-slack-C02NWDZBL0H
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist