Stepper: Add a flag to skip the calypso_signup_start on sign up flows

[gabrielcaires]

Solves part of #91280

Proposed Changes

• Move all calypso_signup_start to a separate hook with automated tests.
• Add a signed_up flag to skip the calypso_signup_start event when the user backs from the /account/user page.

Why are these changes being made?

We observed duplicated instance of calypso_signup_start. It is caused by the follow sequence of user interactions:

• A non-logged user starts a signup flow (e.g. /setup/migration-signup)
• The flow will trigger the calypso_signup_start
• The user is redirected to /account/users with a redirect_to query param
• After the login/signing the user is redirected back to the original flow
• The original flow calls the calypso_signup_start again

The overall idea is to add a flag to the redirect_to param to indicate the user is backing from a sign-in flow.

Note

I am going to add the flag on the redirect_to on my next PR.

Testing Instructions

• Open any flow with the flag isSignupFlow (E.g /setup/migration-signup)
• Check if the event calypso_signup_start was triggered
• Add the flag signed_up=1 to the current URL (E.g. /setup/migration-signup/site-migration-identify?siteSlug=YOUR_SITE&signed_up=1
• Reload the page and check if no calypso_signup_start is triggered.

/

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-96fd512f6ddd1ebe40d9d4de7fb0b5b56a4f3801

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-96fd512f6ddd1ebe40d9d4de7fb0b5b56a4f3801&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-96fd512f6ddd1ebe40d9d4de7fb0b5b56a4f3801&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~28 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +101 B  (+0.0%)      +28 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[valterlorran]

Working as expected! One question tho: Are we supposed to fire the calypso_signup_step_start event even with the signed_up flag?

[daledupreez]

One question tho: Are we supposed to fire the calypso_signup_step_start event even with the signed_up flag?

I think we should, yes: if the user views the step, we should trigger the event to show that they viewed the step. To me that makes sense.