Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monetize: move export supporters button to fix issues with infinite scroll #89111

Closed
wants to merge 2 commits into from

Conversation

simison
Copy link
Member

@simison simison commented Apr 2, 2024

Resolves #89108

Proposed Changes

  • Moves export button from footer to header, to avoid issues with infinite scrolling on longer lists.
  • Change button copy to simpler "Export" to be in line with other export functionality elsewhere (content, subscribers).
Screenshot 2024-04-02 at 14 20 35 Screenshot 2024-04-02 at 14 21 00

I left the mobile version as-is for now:

Screenshot 2024-04-02 at 14 39 14

Testing Instructions

  • With paid subscribers on the site, load /earn/supporters/SITE with different screen sizes.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@simison simison added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Earn labels Apr 2, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/monetize-supporters-move-export-button on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~36 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
earn       +205 B  (+0.0%)      +36 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@simison simison requested review from millerf and a team April 2, 2024 11:54
@crisbusquets
Copy link
Contributor

Works for me, @simison !

I agree with what you mentioned here (#89108 (comment)):

Moved the button to the table heading in #89111 since that was the simplest approach with the current code structure.
It's also semantically at the right level since heading is shared between other pages.

@simison
Copy link
Member Author

simison commented Apr 2, 2024

Closing as we'll need more work at the backend for better UX; the placement like this won't work since downloading full list works only once they've scrolled through the whole list.

@simison simison closed this Apr 2, 2024
@simison simison deleted the update/monetize-supporters-move-export-button branch April 2, 2024 16:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Earn [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monetize: Improve the "Download CSV" button.
3 participants