-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media: Show Storage Count to 2 Decimal Places When <1% #86124
Media: Show Storage Count to 2 Decimal Places When <1% #86124
Conversation
I remember we intentionally rounded those numbers in the past (4225-gh-Automattic/dotcom-forge#issuecomment-1771983829). @obenland, would you recall if that was also to avoid support? If you decide to move that forward @Aurorum, please also check the native version of it to ensure it works the same way: 4225-gh-Automattic/dotcom-forge#issuecomment-1766931148 |
Thanks! I'm afraid that's a private repo so I can't see what it refers to, but I think this rounding would only be for the display anyway? |
That's correct, the rounding was only for displaying it to the user. |
Is that something that happens on a wider scale? If not, let's leave it as is and keep it visually simpler. |
Apologies for my delay @Aurorum – I think this makes perfect sense! The only time I run into this in chat is when there is less than 1% usage, as customers think there's a bug because their usage then says 0%, so I think this would sufficiently address that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working as expected! Nice work @Aurorum!
Less than 1%: | More than 1% |
---|---|
Thanks so much for your contribution @Aurorum! |
* Media: Show Storage Count to 2 Decimal Places * Only apply to <1%
Fixes #83556
Proposed Changes
The idea - in theory anyway - is that this will stop users contacting Support concerned about a 'bug' of their storage count not working; in practice, their storage capacity is just so great that it still rounds to 0%.
I don't mind restricting this to sites with less than 1% of storage, but I didn't see the harm in including this for all sites.
Testing Instructions
A code review is probably sufficient to be honest, but you can see this in the Media Library. The 0% issue is most notable on a site with a lot of storage and a fair amount of files, causing users to be confused about the storage limit breaking.
cc @paulopmt1 @lupus2k: looks like you touched this last - would you mind giving it a quick spin if you have a second? Thanks!