Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes global view - adapt theme preview for content frame. #92645

Closed
Addison-Stavlo opened this issue Jul 12, 2024 · 5 comments · Fixed by #94038
Closed

Themes global view - adapt theme preview for content frame. #92645

Addison-Stavlo opened this issue Jul 12, 2024 · 5 comments · Fixed by #94038
Assignees

Comments

@Addison-Stavlo
Copy link
Contributor

Addison-Stavlo commented Jul 12, 2024

Currently when viewing the theme showcase at global view, clicking in to preview a theme shifts the interface away from global view.

We should find a way to keep the interface more consistent, such as showing the preview inside the global views content frame.

themes-goo

Note - that the Showcase exists as logged-in (single site, all sites) and logged-out. So any change should be tested in all cases

@javierarce javierarce self-assigned this Aug 20, 2024
@javierarce
Copy link

javierarce commented Aug 20, 2024

This is a quick mockup, but perhaps we could use the collapsed sidebar and do something like this:

image

For the navigation we could use the Plugin breadcrumb.

@Addison-Stavlo
Copy link
Contributor Author

Addison-Stavlo commented Aug 20, 2024

perhaps we could use the collapsed sidebar and do something like this:

Its not a bad idea but I think we want to be consistent with when we do and don't collapse the sidebar. The plugins browser in global for example shows individual plugins within the content frame with the sidebar open:

Screenshot 2024-08-20 at 4 34 11 PM

Originally writing this issue, I didn't expect needing a new design and we would literally just put the individual theme page inside the exact same content frame that the theme browser is in here:

Screenshot 2024-08-20 at 4 33 59 PM

If we wanted to use the collapsed sidebar, we should probably be consistent and do that with the plugins pages as well (not sure about others like domains?)

Or for now, just use the existing content frame and sidebar? It feels more like a bug that it breaks out of that to view the individual items.

@javierarce
Copy link

Or for now, just use the existing content frame and sidebar? It feels more like a bug that it breaks out of that to view the individual items.

Yes, sorry, let's do that. I originally thought we weren't displaying the regular left sidebar because we didn't want to shrink the columns, but I ran a quick test (which I should have done before publishing my first comment, sorry), and it's not too bad.

@davemart-in
Copy link
Contributor

Originally writing this issue, I didn't expect needing a new design and we would literally just put the individual theme page inside the exact same content frame that the theme browser is in

Let's do this @Addison-Stavlo. 👍

@allilevine
Copy link
Member

I opened #93928 to fix. It'll need a couple of follow-ups like highlighting the menu item and changing the header, to be closer to the Plugins experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants