Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Update Learn more link in the UTM overlay #87925

Open
grzegorz-cp opened this issue Feb 27, 2024 · 2 comments
Open

Stats: Update Learn more link in the UTM overlay #87925

grzegorz-cp opened this issue Feb 27, 2024 · 2 comments
Assignees
Labels
[Feature] Stats Everything related to our analytics product at /stats/

Comments

@grzegorz-cp
Copy link
Contributor

grzegorz-cp commented Feb 27, 2024

UTM module overlay that has an Upgrade button also has a Learn more link. Currently, it links to <InlineSupportLink /> verify if this is correct or update it.

Design

Image

@grzegorz-cp grzegorz-cp added the [Feature] Stats Everything related to our analytics product at /stats/ label Feb 27, 2024
@CGastrell CGastrell assigned CGastrell and unassigned CGastrell Nov 12, 2024
@dognose24
Copy link
Contributor

Discussion for alignment: p1731421374796769-slack-C82FZ5T4G.

@dhasilva
Copy link
Contributor

Right, so after the last PR I tried making the InlineSupportLink work, but there seems to be an issue on build time. The component is imported, but it has nothing in it, and the React devtools says its source is "unknown". Since it does not have a render method on runtime, it leads to the problem that was addressed in the last PR.
I made a test PR to check if the render method would be available on Calypso Live, but it is not.

Since this seems to be a much more complicated issue dealing with how Stats is built, but it has not been resolved, I'm removing it from the parent issue instead of closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

No branches or pull requests

4 participants