Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadrat: fix triangles #8579

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Quadrat: fix triangles #8579

wants to merge 2 commits into from

Conversation

MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Jan 15, 2025

Changes proposed in this Pull Request:

This PR fixes the triangles on Quadrat both on the editor and frontend. This code has always been brittle and it broke because the editor changed. I think I fixed it for some kind of attachment to the code that I initially wrote myself and because this is the intended design, but my suggestion is if it breaks again, we should remove it.

Screenshot 2025-01-15 at 12 23 31

Related issue(s):

Closes #5378

@MaggieCabrera MaggieCabrera self-assigned this Jan 15, 2025
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Quadrat.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.
Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

Copy link
Contributor

Theme-Check results

quadrat: No changes required ✅.

⚠️ WARNING (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quadrat and its child themes: Header triangle image looks different in the editor vs frontend
1 participant