Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitrum: fixes issues mentioned on issue 8500 #8554

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

henriqueiamarino
Copy link
Collaborator

This PR fixes the issues mentioned in issue #8500 by @iamtakashi.

  • Fixed the button padding and stroke sizes;
  • Adjusted contentSize to 1050px;
  • Remove unused patterns patterns/about.php, and patterns/hidden-404.php;
  • On readme.txt and style.css: Change Tested up to: to 6.7 and Requires PHP: to 7.0;
  • Reviewed the image credits, removing unnecessary links;
  • Removed theme tags and added the mentioned one;
  • Removed duplicated comment is duplicated in style.css;
  • Removed several numeric font sizes in the theme, replacing them with preset type sizes;
  • Changed the theme version to 1.4.0 in style.css.

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Vitrum.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@henriqueiamarino henriqueiamarino mentioned this pull request Dec 30, 2024
6 tasks
…s since they have strings need to be localised
Copy link
Contributor

Theme-Check results

vitrum: No changes required ✅.


@iamtakashi
Copy link
Contributor

iamtakashi commented Jan 13, 2025

Thanks for the updates @henriqueiamarino! The changes all look great.

I only pushed a change that made the following templates patterns since they had some strings that needed to be localised. 404, archives, index, search, and single posts. I just resaved those templates with the CBT.

Merging.

@iamtakashi iamtakashi merged commit 65fbed7 into trunk Jan 13, 2025
3 checks passed
@iamtakashi iamtakashi deleted the update/vitrum branch January 13, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants