Remove Settings > Performance menu item

[lsl]

Fixes Automattic/wp-calypso#98196

Proposed changes:

• Remove Settings > Performance menu item for atomic and simple sites when the user is in the treatment group 22167-explat-experiment

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Simple site:

• Apply changes using the sandbox scripts below (mu plugin)
• Confirm Performance menu item no longer shows up in the response of /wpcom/v2/sites/:site/admin-menu https://developer.wordpress.com/docs/api/console/ for your simple site.
• Confirm the same for wp-admin and calypso menus

Atomic site:

• Apply changes using beta test plugin, select this branch update/remove-performance-menu-item for:
  • Jetpack if JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN is undefined or false
  • WP.com Features if JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN is defined and true
• Confirm the Settings > Performance menu item no longer shows up in the response of /wpcom/v2/sites/:site/admin-menu https://developer.wordpress.com/docs/api/console/ for your woa dev site.
• Confirm the same for wp-admin and calypso menus

Before	After

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/remove-performance-menu-item branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/remove-performance-menu-item
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/remove-performance-menu-item
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[okmttdhr]

@lsl
@taipeicoder conducted an audit of the Settings > Performance (pbxlJb-6rj-p2#settings-performance), and it appears that we aimed to keep the upsells while consolidating them into a single UI. There were discussions about merging all Jetpack upsells into a single full-page upsell (e.g., Activity Log, Backup, and Search) (pbxlJb-6sE-p2#jetpack-activity-log). I'm unsure about the actions taken regarding these discussions—apologies for not being up to date! 🙇‍♂️
Should we address these upsell items before removing them?

[taipeicoder]

Given that they are all low-performing upsells and have poor click conversions, I don't think they should block this task.
@crisbusquets and @nuriapenya are working on rethinking how we go about upsells in WP.com, we should look forward and contribute to that effort instead.

[okmttdhr]

☝️ Make sense. Thanks for the confirmation!

---

• I confirmed that Settings > Performance is not displayed:
  • on Atomic Default both in calypso and wp-admin pages. ✅
  • on Simple Default both in calypso and wp-admin pages. ✅
• In Atomic Classic, I verified that Settings > Performance:
  • Is displayed and linked to /wp-admin/options-general.php?page=page-optimize when the Page Optimize plugin is enabled. ✅
  • Is not displayed when the Page Optimize plugin is disabled. ✅

Since we are removing this menu item, does this PR also address Automattic/wp-calypso#93964?

[lsl]

We should probably make this so that the page-optimize link doesn't show on any sites, it's a little confusing because it conflicts with Jetpack, but is linked from jetpack as well.

Thoughts?

[taipeicoder]

We should probably make this so that the page-optimize link doesn't show on any sites, it's a little confusing because it conflicts with Jetpack, but is linked from jetpack as well.

Thoughts?

Currently, the setting Jetpack links to /wp-admin/admin.php?page=page-optimize

It leads to no sidebar item selected since it should be /wp-admin/options-general.php?page-optimize (bug?)

We should probably keep the sidebar item Settings > Performance when page-optimize is active, so that there is a corresponding sidebar menu item.

[okmttdhr]

I wasn’t aware that Jetpack links to wp-admin/options-general.php?page=page-optimize. I don't have a strong preference, but consolidating performance options seems logical, and hiding this on all sites could be a good idea.

I also verified that the link is not displayed when Page Optimize is disabled.

Can we use Page Optimize standalone (without Jetpack)? I'm a bit concerned that adding extra logic to determine whether to display the menu based on Jetpack’s presence might increase complexity.

[okmttdhr]

We should probably keep the sidebar item Settings > Performance when page-optimize is active, so that there is a corresponding sidebar menu item.

Oh that makes sense.

[keoshi]

Hi, friends! Filipe from "Jetpack Design" here. 👋

Thanks for having this discussion. If it helps frame the conversation, the Jetpack experience should be the same regardless of host. That's how we've been approaching these problems.

Because we've added so much complexity to WordPress.com in general and Atomic sites in particular, it's hard to disconnect from the tangled web we've created for ourselves. Would encourage everyone to take a self-hosted site and see what the current Jetpack experience is. Not saying it's ideal, but at least that experience is consistent across multiple web hosts. The exception is WordPress.com.

Having said that, I do not see additional links under the Performance & speed options:

So I would assume that's another exception we've created for Atomic and can be removed. If not now, certainly in the future.

As for the Settings → Performance page, there isn't anything unique that isn't also mirrored in Jetpack, except for the Cloudflare CDN. That's a WordPress.com-only feature (see p7DVsv-aU8-p2 for more details), so probably worth surfacing at the hosting-level. cc @matt-west

[matt-west]

As for the Settings → Performance page, there isn't anything unique that isn't also mirrored in Jetpack, except for the Cloudflare CDN. That's a WordPress.com-only feature (see p7DVsv-aU8-p2 for more details), so probably worth surfacing at the hosting-level

We could rename the Caching page that’s under Settings at the hosting-level to Performance and show the CDN card there. It probably still makes sense to highlight both Jetpack and Cloudflare. The IA would become:

Performance
- All caches
- Global edge cache
- Object cache
- CDN

[keoshi]

That seems perfect, @matt-west — thank you for jumping in so quickly!