Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin bar: don't enqueue obsolete Core CSS overrides for Default scheme #39453

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Sep 19, 2024

Fixes:

Proposed changes:

This PR ensures that we're not enqueuing any obsolete CSS overrides for the Default scheme. After pfsHM7-1kz-p2, such overrides are not required anymore. However, #39371 accidentally re-added them because it re-registers the fresh scheme using our CSS file (which contains the override).

This PR fixes that by just removing the override inclusion from that CSS file.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Prepare a NEW Woa site.
    • It is important so that you won't get the cached colors.css.
    • Don't forget to add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); in wp-config.php
  2. Patch this to Jetpack Beta Tester (WP.com Features)
  3. Go to Users -> Profile and change the color scheme to Default.
  4. Verify that the admin bar background color is #c3c4c7.
  5. Verify that no colors are broken.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/fresh-masterbar branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/fresh-masterbar
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/fresh-masterbar
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Package] Masterbar [Status] In Progress labels Sep 19, 2024
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@fushar fushar marked this pull request as ready for review September 19, 2024 10:13
@fushar fushar requested a review from a team September 19, 2024 10:13
@fushar fushar removed the [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations label Sep 19, 2024
@fushar fushar self-assigned this Sep 19, 2024
@fushar fushar added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations and removed [Status] In Progress labels Sep 19, 2024
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 19, 2024
@fushar fushar merged commit e2c99cc into trunk Sep 24, 2024
62 of 63 checks passed
@fushar fushar deleted the fix/fresh-masterbar branch September 24, 2024 04:45
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Package] Masterbar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant