Materialize before returning data from GetAll calls, tested this time

Artemis-RGB · Mar 12, 2024 · f66df43 · f66df43
1 parent 1196a95
commit f66df43
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/src/Artemis.Storage/Repositories/DeviceRepository.cs b/src/Artemis.Storage/Repositories/DeviceRepository.cs
@@ -28,10 +28,10 @@ public void Remove(DeviceEntity deviceEntity)
         return dbContext.Devices.FirstOrDefault(d => d.Id == id);
     }
 
-    public IEnumerable<DeviceEntity> GetAll()
+    public List<DeviceEntity> GetAll()
     {
         using ArtemisDbContext dbContext = getContext();
-        return dbContext.Devices.AsEnumerable();
+        return dbContext.Devices.ToList();
     }
 
     public void Save(DeviceEntity deviceEntity)

diff --git a/src/Artemis.Storage/Repositories/EntryRepository.cs b/src/Artemis.Storage/Repositories/EntryRepository.cs
@@ -34,10 +34,10 @@ public void Remove(EntryEntity entryEntity)
         return dbContext.Entries.FirstOrDefault(s => s.EntryId == entryId);
     }
 
-    public IEnumerable<EntryEntity> GetAll()
+    public List<EntryEntity> GetAll()
     {
         using ArtemisDbContext dbContext = getContext();
-        return dbContext.Entries.AsEnumerable();
+        return dbContext.Entries.ToList();
     }
 
     public void Save(EntryEntity entryEntity)

diff --git a/src/Artemis.Storage/Repositories/Interfaces/IDeviceRepository.cs b/src/Artemis.Storage/Repositories/Interfaces/IDeviceRepository.cs
@@ -8,7 +8,7 @@ public interface IDeviceRepository : IRepository
     void Add(DeviceEntity deviceEntity);
     void Remove(DeviceEntity deviceEntity);
     DeviceEntity? Get(string id);
-    IEnumerable<DeviceEntity> GetAll();
+    List<DeviceEntity> GetAll();
     void Save(DeviceEntity deviceEntity);
     void SaveRange(IEnumerable<DeviceEntity> deviceEntities);
 }
diff --git a/src/Artemis.Storage/Repositories/Interfaces/IEntryRepository.cs b/src/Artemis.Storage/Repositories/Interfaces/IEntryRepository.cs
@@ -10,6 +10,6 @@ public interface IEntryRepository : IRepository
     void Remove(EntryEntity entryEntity);
     EntryEntity? Get(Guid id);
     EntryEntity? GetByEntryId(long entryId);
-    IEnumerable<EntryEntity> GetAll();
+    List<EntryEntity> GetAll();
     void Save(EntryEntity entryEntity);
 }
diff --git a/src/Artemis.Storage/Repositories/Interfaces/IProfileCategoryRepository.cs b/src/Artemis.Storage/Repositories/Interfaces/IProfileCategoryRepository.cs
@@ -8,7 +8,7 @@ public interface IProfileCategoryRepository : IRepository
 {
     void Add(ProfileCategoryEntity profileCategoryEntity);
     void Remove(ProfileCategoryEntity profileCategoryEntity);
-    IEnumerable<ProfileCategoryEntity> GetAll();
+    List<ProfileCategoryEntity> GetAll();
     ProfileCategoryEntity? Get(Guid id);
     bool IsUnique(string name, Guid? id);
     void Save(ProfileCategoryEntity profileCategoryEntity);

diff --git a/src/Artemis.Storage/Repositories/ProfileCategoryRepository.cs b/src/Artemis.Storage/Repositories/ProfileCategoryRepository.cs
@@ -25,7 +25,7 @@ public void Remove(ProfileCategoryEntity profileCategoryEntity)
         dbContext.SaveChanges();
     }
 
-    public IEnumerable<ProfileCategoryEntity> GetAll()
+    public List<ProfileCategoryEntity> GetAll()
     {
         if (!_migratedProfiles)
         {
@@ -34,7 +34,7 @@ public IEnumerable<ProfileCategoryEntity> GetAll()
         }
 
         using ArtemisDbContext dbContext = getContext();
-        return dbContext.ProfileCategories.Include(c => c.ProfileConfigurations).AsEnumerable();
+        return dbContext.ProfileCategories.Include(c => c.ProfileConfigurations).ToList();
     }
 
     public ProfileCategoryEntity? Get(Guid id)