Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Cardinal documentation with latest features #820

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 11, 2024

Updates documentation to reflect current Cardinal implementation.

Changes include:

  • Add comprehensive plugin system documentation
  • Add world stages documentation and lifecycle management
  • Update component and query documentation
  • Add advanced tutorials for plugin development and world lifecycle
  • Update navigation structure with new tutorials section

Link to Devin run: https://app.devin.ai/sessions/96881ecd4cda4a2fb42d38d70a306de1

  • Fixed broken link in world-lifecycle.mdx

devin-ai-integration bot and others added 3 commits December 11, 2024 01:30
- Add plugin system documentation
- Add world stages documentation
- Update component and query docs
- Update navigation structure

Adds comprehensive documentation for:
- Plugin system architecture and usage
- World stage lifecycle management
- Component validation and defaults
- Query groups and EVM integration

Co-Authored-By: Scott Sunarto <me@smsunarto.com>
Co-Authored-By: Scott Sunarto <me@smsunarto.com>
Co-Authored-By: Scott Sunarto <me@smsunarto.com>
Copy link

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment on lines +228 to +240
func monitorStages(world *cardinal.World) {
for {
select {
case <-world.NotifyOnStage(worldstage.Starting):
handleStarting(world)
case <-world.NotifyOnStage(worldstage.Running):
handleRunning(world)
case <-world.NotifyOnStage(worldstage.ShuttingDown):
handleShutdown(world)
return
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating notification channels inside the select statement can lead to missed notifications since the channels are recreated on each loop iteration. To ensure reliable stage monitoring, create the notification channels once before entering the select:

startingCh := world.NotifyOnStage(worldstage.Starting)
runningCh := world.NotifyOnStage(worldstage.Running) 
shutdownCh := world.NotifyOnStage(worldstage.ShutDown)

for {
    select {
    case <-startingCh:
        // ...
    }
}

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

Co-Authored-By: Scott Sunarto <me@smsunarto.com>
Copy link

Preview Instructions

To preview these changes locally, checkout this branch and run:

make world-docs

devin-ai-integration bot and others added 2 commits December 11, 2024 02:06
Co-Authored-By: Scott Sunarto <me@smsunarto.com>
Co-Authored-By: Scott Sunarto <me@smsunarto.com>
Copy link

Preview Instructions

To preview these changes locally, checkout this branch and run:

make world-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants