Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TNTableViewDataSource] Enhancements #11

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions TNTableViewDataSource.j
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,21 @@
return [_filteredContent count];
}

#pragma mark -
#pragma mark Helpers

/*! expose selected objects
@return array of selected objects or nil if _table is not setted
*/
- (CPArray)selectedObjects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to check if _table is not nil here

{
if (_table)
{
return [_filteredContent objectsAtIndexes:[_table selectedRowIndexes]];
}

return nil;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may seem "pointilleux" but following the style I use, this should be:

if (!_table)
    return nil;
return [_filteredContent objectsAtIndexes:[_table selectedRowIndexes]];

}

#pragma mark -
#pragma mark Datasource implementation
Expand Down