test: tests for nine more proxies #2467
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
reviewed
Jan 13, 2025
| split = Clones.clone(_implementation); | ||
| emit Target(split); | ||
| } | ||
| } |
There was a problem hiding this comment.
make sure all files end in a newline ◡̈
Suggested change
| } | |
| } | |
fubuloubu
reviewed
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR adds to #760 tests for the following proxies:
The tests for the following proxies failed: SoladyCWIA, SplitsCWIA,Vyper and OldCWIA. The pattern that the function
get_proxy_infotries to identify can not be found in the proxy bytecode after compilation. I am unsure whether the issue lies in the compilation (perhaps optimizations are altering the bytecode) or if I am using the wrong proxy for the test. Something weird happens with two of them ( Vyper and SoladyCWIA),they are identified as Minimal proxies.Regarding the other proxies (VyperBeta, and ZeroAge), I cannot find the test code for these proxies. Could you assist me with that?
fixes: #760