fix: custom network would sometimes use the wrong provider class #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This bug did not reveal itself until functionality was required on it, meaning it always was doing this but never mattered until now.
It is supposed to use the generic Node class, not GethDev, but they both come from the same provider and the order is not deterministic so sometimes it would be one or the other. However, the chain ID caching mechanism fails if it is does not use the Node class (as of #2464), so it became a bug at that point, thankfully not released yet.
fixes: #2449 (comment)
How I did it
adjust if statement to ensure right class
How to verify it
you can consistently use custom networks again
Checklist