Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction was missing signature / couldn't get hash when came from receipt #2446

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

antazoey
Copy link
Member

What I did

fixes: #2438
Fixes: APE-1867

How I did it

add it in manually

How to verify it

receipt.transaction.txn_hash should not fail with sig error

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

fubuloubu
fubuloubu previously approved these changes Dec 23, 2024
@antazoey antazoey merged commit 587fc48 into ApeWorX:main Dec 23, 2024
18 checks passed
@antazoey antazoey deleted the fix/receipt-transaction-hash branch December 24, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

receipt.transaction.txn_hash fails even when receipt.txn_hash does not fail
2 participants