Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where used SharedBlobReceipt instead of Receipt #2421

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

antazoey
Copy link
Member

What I did

some tests in foundry show up using SharedBlobReceipt which seemed odd.. They had 1 field blob_gas_price: 1, seems like just random data coming along.. hoping this solution is more precise

How I did it

rely on type being 3

How to verify it

tell me if im wrong i guess, i havent fully researched and am just going off my understanding, i dont really blob

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey force-pushed the fix/wrong-receipt-cls branch from 66b8dc4 to f81c0b4 Compare December 18, 2024 00:46
@antazoey antazoey force-pushed the fix/wrong-receipt-cls branch from 1ac8289 to c4d4c23 Compare December 18, 2024 04:20
@antazoey antazoey marked this pull request as ready for review December 18, 2024 16:05
@antazoey antazoey requested a review from fubuloubu December 18, 2024 16:05
@antazoey antazoey merged commit 0a0814a into ApeWorX:main Dec 18, 2024
18 checks passed
@antazoey antazoey deleted the fix/wrong-receipt-cls branch December 18, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants