feat: allow --show-internal to be configured and use in framework's tests
#2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwise-constructs
previously approved these changes
Dec 16, 2024
bitwise-constructs
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I noticed the last fail on merge to main failed...
I then realized some of the stack-trace is missing.. hmm..
Coincidentally, I also noticed this in
ape-safe, which also uses Ape to test itself.Thus, I remember the cursed
--show-internalflag.How can I just configured this on? Well I could use pytest's
addoptsbut that always messy to me and is more of a last resort.Instead, I made it so you can configure ape this way.
Then I remember I can configure Ape right in the Ape pyproject.toml file. Rad.
This makes sense to be configured for the framework itself, since that is its point