refactor: create and use disk-cache utilities for contracts-cache items #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
feat/disk-cachable-models
branch
from
07027d9 to
2080314
Compare
bitwise-constructs
previously approved these changes
Dec 16, 2024
| class CacheDirectory: | ||
| """ | ||
| A directory for caching data where each data item is named | ||
| ``<key>.json`` and is in the directory. You can access the |
There was a problem hiding this comment.
should this have some prefix like cache_<key>.json?
There was a problem hiding this comment.
maybe, or all in /caches sub-folder but i dont want to change the structure now as it will be too breaking
bitwise-constructs
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
OK This is a big refactor for the contract-type caching related code. Nothing is breaking but there is a lot more public stuff added. This makes thing way easier to use both for us and for users. We can no more easily improve the caching features, which is what I was trying to do for 0.9.
How I did it
Make a base model for writing and reading from Disk
Make some stuff to help the deployments JSON patrick added a while back.
Incorporate this stuff into the caches for chain.contracts, deleting lots of repetitious code along the way.
Move contract caching stuff to its own module for faster loading.
The list goes on!
How to verify it
looking for everything working pretty much as it did, except there are some new toolings and methods as well, which is now used all over our tests.
Checklist