Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where KeyfileAccount would not stay unlocked [APE-1586] #1755

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Dec 5, 2023

What I did

In ape-safe, I was prompted "Leave unlocked?" over and over again and it was because signers were re-checked and reloaded and thus lost the "yes" to my prompt... So it is would be nice if Ape remembered I said "yes" to leave the account unlocked.

How I did it

Only create the KeyfileAccount class once.

How to verify it

see second test. The first one was me trying to figure out but is still a nice test

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@vany365 vany365 changed the title fix: issue where account would not stay unlocked fix: issue where account would not stay unlocked [APE-1586] Dec 5, 2023
@antazoey antazoey changed the title fix: issue where account would not stay unlocked [APE-1586] fix: issue where KeyfileAccount would not stay unlocked [APE-1586] Dec 5, 2023
@antazoey
Copy link
Member Author

antazoey commented Dec 5, 2023

I guess one may want it to be relocked on when calling load() again? in which case, the caching can happen at the ape-safe level.
But it is just prone to be a problem again in future applications...

There is .lock() method you can and should call anyway.. to relock the account... It was just frustrating to have always bash "yes, leave unlocked" and it is just never stayed unlocked-

fubuloubu
fubuloubu previously approved these changes Dec 5, 2023
@antazoey antazoey merged commit f292af3 into ApeWorX:main Dec 6, 2023
15 checks passed
@antazoey
Copy link
Member Author

antazoey commented Dec 6, 2023

was approved before, all i did was make tests happy since

@antazoey antazoey deleted the fix/leaveunlocked branch December 6, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants