fix: issue where KeyfileAccount
would not stay unlocked [APE-1586]
#1755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In ape-safe, I was prompted
"Leave unlocked?"
over and over again and it was because signers were re-checked and reloaded and thus lost the "yes" to my prompt... So it is would be nice if Ape remembered I said "yes" to leave the account unlocked.How I did it
Only create the
KeyfileAccount
class once.How to verify it
see second test. The first one was me trying to figure out but is still a nice test
Checklist