fix: issue where arrays were missing in logs [APE-1501]

[z80dev]

What I did

Added a failing test case for the weird missing event data

Fixes: APE-1465

How I did it

How to verify it

Checklist

• All changes are completed
• New test cases have been added
• Documentation has been updated

[linear]

APE-1501 "feat: add failing test for missing event data" (ApeWorX/ape #1722)

What I did

Added a failing test case for the weird missing event data

How I did it

How to verify it

Checklist

• All changes are completed
• New test cases have been added
• Documentation has been updated

---

ApeWorX/ape #1722 by z80dev on GitHub

via LinearSync

[antazoey]

thank you - gonna TDD this

[linear]

APE-1465 Event Regression in 0.6.20

1. Went back to 0.6.19 and it's working again - going to incrementally install each version to pin it down

2. ***[*2:38 PM]

   well that didn't take long lol it's in 0.6.20

3. ***[*2:39 PM]

   well actually

4. ***[*2:39 PM]

   it looks like in .20 they're reading but tuples have turned into lists

5. ***[*2:40 PM]

   lists of lists

6. ***[*2:40 PM]

   if it's helpful, here's the logs (you can see the previously-passing expected values)

7. ***[*2:40 PM]

   FAILED tests/test_poppets.py::TestPoppetReveals::test_reveal_one - assert 2 in [[2]]
   FAILED tests/test_poppets.py::TestPoppetReveals::test_force_reveal - assert 3 in [[3]]
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_simple - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_simple_zeroed_amounts - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_simple_zeroed_amounts_confirm_bug - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_one_on_none_off - assert [[]] == ()
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_none_on_one_off - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_with_fee - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owned_poppets - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owned_poppets_zeroed_amounts - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owned_poppets_zeroed_amounts_confirm_bug - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owners - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owners_zeroed_amounts - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owners_zeroed_amounts_confirm_bug - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_community_traits - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_community_traits_with_fee - assert [[1]] == (1,)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_community_traits_between_owned_poppets - assert [[1000, 2000, 3000]] == (1000, 2000, 3000)
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_community_traits_between_owners - assert [[1000, 2000, 3000]] == (1000, 2000, 3000)
   

8. ***[*2:42 PM]

   . . Then 0.6.21 they're gone altogether . .

9. ***[*2:42 PM]

   FAILED tests/test_poppets.py::TestPoppetReveals::test_reveal_one - IndexError: Unable to find 'token_ids' in any of 'PoppetsRevealed'.
   FAILED tests/test_poppets.py::TestPoppetReveals::test_force_reveal - IndexError: Unable to find 'token_ids' in any of 'PoppetsRevealed'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_simple - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_simple_zeroed_amounts - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_simple_zeroed_amounts_confirm_bug - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_one_on_none_off - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_none_on_one_off - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_with_fee - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owned_poppets - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owned_poppets_zeroed_amounts - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owned_poppets_zeroed_amounts_confirm_bug - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owners - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owners_zeroed_amounts - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_traits_between_owners_zeroed_amounts_confirm_bug - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_community_traits - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_community_traits_with_fee - IndexError: Unable to find 'removed_official' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_community_traits_between_owned_poppets - IndexError: Unable to find 'removed_community' in any of 'PoppetTraitsUpdated'.
   FAILED tests/test_poppets.py::TestPoppetTraitSwaps::test_swap_community_traits_between_owners - IndexError: Unable to find 'removed_community' in any of 'PoppetTraitsUpdated'.
   

10. ***[*2:43 PM]

    I'm going to drop back down to 0.6.19 for the moment, but hopefully someone has some insights

11. ***[*2:44 PM]

    Also TIL if you push to arrays in your constructor, etherscan will never ever ever verify - but if you pass them as constructor arguments, it works fine

you can find convo in discord here:

https://discord.com/channels/922917176040640612/954593641970696292/1163542114215399424