feat: account list filter in Ape alias CLI options #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
antazoey
changed the title
5 tasks
fubuloubu
reviewed
Oct 31, 2023
fubuloubu
previously approved these changes
Oct 31, 2023
antazoey
force-pushed
the
feat/account-list-filter-by-account
branch
from
8652776 to
fac6ef5
Compare
antazoey
force-pushed
the
feat/account-list-filter-by-account
branch
from
fac6ef5 to
0880b44
Compare
fubuloubu
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Allows me to do:
^ There is some helpful logic and handling in that method that I otherwise would have to copy in order to handle all the scenarios of best selecting an account and such, I think this is one good stop to improving some of the UX of ape-safe.
How I did it
How to verify it
Checklist