fix: issue with fee history for some nodes (#1812)

src/ape/utils/basemodel.py

@@ -240,7 +240,7 @@ def __ape_extra_attributes__(self) -> Iterator[ExtraModelAttributes]:
     def __getattr__(self, name: str) -> Any:
         """
         An overridden ``__getattr__`` implementation that takes into
-        account :meth:`~ape.utils.basemodel.BaseModel.__ape_extra_attributes__`.
+        account :meth:`~ape.utils.basemodel.ExtraAttributesMixin.__ape_extra_attributes__`.
         """
 
         private_attrs = self.__pydantic_private__ or {}

src/ape_ethereum/provider.py

@@ -38,7 +38,7 @@
 from web3.middleware.validation import MAX_EXTRADATA_LENGTH
 from web3.providers import AutoProvider
 from web3.providers.auto import load_provider_from_environment
-from web3.types import RPCEndpoint, TxParams
+from web3.types import FeeHistory, RPCEndpoint, TxParams
 
 from ape.api import BlockAPI, ProviderAPI, ReceiptAPI, TransactionAPI
 from ape.api.networks import LOCAL_NETWORK_NAME
@@ -161,8 +161,8 @@ def base_fee(self) -> int:
             return 0
 
         try:
-            fee_history = self.web3.eth.fee_history(1, BlockNumber(latest_block_number))
-        except ValueError as exc:
+            fee_history = self._get_fee_history(latest_block_number)
+        except Exception as exc:
             # Use the less-accurate approach (OK for testing).
             logger.debug(
                 "Failed using `web3.eth.fee_history` for network "
@@ -181,6 +181,14 @@ def base_fee(self) -> int:
 
         return pending_base_fee
 
+    def _get_fee_history(self, block_number: int) -> FeeHistory:
+        # NOTE: Have to `reward_percentiles=[]` because of this bug:
+        #   https://github.com/ethereum/web3.py/issues/3184
+        try:
+            return self.web3.eth.fee_history(1, BlockNumber(block_number), reward_percentiles=[])
+        except MethodUnavailable as err:
+            raise APINotImplementedError(str(err)) from err
+
     def _get_last_base_fee(self) -> int:
         block = self.get_block("latest")
         base_fee = getattr(block, "base_fee", None)

tests/functional/test_provider.py

@@ -374,3 +374,13 @@ def custom_make_request(rpc, params):
         match="RPC method 'ape_thisDoesNotExist' is not implemented by this node instance.",
     ):
         eth_tester_provider._make_request("ape_thisDoesNotExist")
+
+
+def test_base_fee(eth_tester_provider):
+    actual = eth_tester_provider.base_fee
+    assert actual > 0
+
+    # NOTE: Mostly doing this to ensure we are calling the fee history
+    #   RPC correctly. There was a bug where we were not.
+    with pytest.raises(APINotImplementedError):
+        _ = eth_tester_provider._get_fee_history(0)