Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cucumber submodule for tests, remove Antares_Simulator_Tests_NR #2440

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Add cucumber submodule for tests, remove Antares_Simulator_Tests_NR #2440

wants to merge 8 commits into from

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Sep 27, 2024

Also, remove some columns from "021 Four areas - DC law" (slight result change)

@flomnes flomnes requested a review from pet-mit September 27, 2024 14:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pet-mit
pet-mit reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@pet-mit pet-mit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of the cucumber tests in the end is to migrate all existing tests in Antares_Simulator_Tests_NR to the new cucumber "run & check" scripts. So we will still need all studies that are in that repo. What purpose does this PR serve?

@flomnes
Copy link
Member Author

flomnes commented Sep 30, 2024

The idea of the cucumber tests in the end is to migrate all existing tests in Antares_Simulator_Tests_NR to the new cucumber "run & check" scripts. So we will still need all studies that are in that repo. What purpose does this PR serve?

To have a smaller repository used only by cucumber tests (faster clone/checkout/etc.)

a-zakir
a-zakir reviewed Oct 7, 2024
View reviewed changes
src/tests/cucumber/features/medium_tests.feature
@@ -2,7 +2,7 @@ Feature: medium tests

@fast @medium @incomplete
Scenario: 035 Mixed Expansion - Smart grid model 2
Given the study path is "medium-tests/035 Mixed Expansion - Smart grid model 2"
Given the study path is "035 Mixed Expansion - Smart grid model 2"
Copy link
Contributor

@a-zakir a-zakir Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can take advantage of this new repo to remove withespaces from study folder

a-zakir
a-zakir reviewed Oct 7, 2024
View reviewed changes
src/tests/cucumber/features/short_tests.feature
| EXP | STD | MIN | MAX |
| 6.5397e+10| 2.97462e+09 | 6.10076e+10 | 6.84837e+10 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight change of results after the study was cleaned up (100 TS -> 3 TS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pet-mit pet-mit pet-mit left review comments

@a-zakir a-zakir a-zakir left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flomnes @a-zakir @pet-mit