fix dialog control

close dialog when lifecycle state is DESTROYED
AlexDeww · Nov 2, 2020 · 75101b1 · 75101b1
1 parent 289d3cc
commit 75101b1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/reactiveviewmodel/src/main/java/com/alexdeww/reactiveviewmodel/widget/DialogControl.kt b/reactiveviewmodel/src/main/java/com/alexdeww/reactiveviewmodel/widget/DialogControl.kt
@@ -4,6 +4,7 @@ import android.app.Dialog
 import androidx.lifecycle.Lifecycle
 import androidx.lifecycle.LifecycleOwner
 import androidx.lifecycle.MediatorLiveData
+import androidx.lifecycle.Observer
 import com.alexdeww.reactiveviewmodel.core.RvmViewComponent
 import io.reactivex.rxjava3.core.Maybe
 
@@ -106,11 +107,11 @@ private class DialogLiveDataMediator<T, R>(
         }
     }
 
-    override fun onInactive() {
+    override fun removeObserver(observer: Observer<in DialogControl.Display>) {
         if (lifecycleOwner.lifecycle.currentState == Lifecycle.State.DESTROYED) {
             closeDialog()
         }
-        super.onInactive()
+        super.removeObserver(observer)
     }
 
     private fun closeDialog() {