Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: expose storage backends metric names for doc generation #612

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

jeqo
Copy link
Contributor

@jeqo jeqo commented Oct 22, 2024

Add a metric registry for Azure, GCS, S3 metrics, document metrics, and expose metric name templates to be used on documentation generation.

@jeqo jeqo marked this pull request as ready for review October 22, 2024 11:41
@jeqo jeqo requested a review from a team as a code owner October 22, 2024 11:41
@jeqo jeqo marked this pull request as draft October 22, 2024 11:42
@jeqo jeqo force-pushed the jeqo/docs-metrics-storages branch from eeb6710 to ef05c49 Compare October 22, 2024 19:37
@jeqo jeqo marked this pull request as ready for review October 22, 2024 21:10
@jeqo jeqo requested a review from biggusdonzus October 22, 2024 21:10
Copy link
Contributor

@biggusdonzus biggusdonzus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@biggusdonzus biggusdonzus merged commit 666924d into main Oct 23, 2024
10 checks passed
@biggusdonzus biggusdonzus deleted the jeqo/docs-metrics-storages branch October 23, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants