Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emojis are not visible on iOS Chrome #609

Merged
merged 5 commits into from
Mar 18, 2024

Conversation

RealGoodProgrammer
Copy link
Member

Fix for hidden emojis selector on Chrome (iOS
image (8)

Copy link

vercel bot commented Mar 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2024 11:17am

Copy link

github-actions bot commented Mar 16, 2024

Deployed to https://msg-adamant-pr-609.surge.sh 🚀

@bludnic
Copy link
Member

bludnic commented Mar 17, 2024

@RealGoodProgrammer Attach the Trello card to the PR

package.json Outdated Show resolved Hide resolved
src/components/EmojiPicker.vue Outdated Show resolved Hide resolved
@bludnic bludnic self-requested a review March 17, 2024 10:24
@bludnic
Copy link
Member

bludnic commented Mar 17, 2024

UI: Add emoji and move attach to the input field (copied from iOS)

@PaulDremanovich
Copy link
Member

Why do you have the positioning property implemented if you keep hardcoding it early? Perhaps you just need to change the style?

@RealGoodProgrammer
Copy link
Member Author

Why do you have the positioning property implemented if you keep hardcoding it early? Perhaps you just need to change the style?

For the case when it should be static. Look at the condition. The class will be applied only when the 'absolute' value is passed to it in the property

@RealGoodProgrammer RealGoodProgrammer merged commit 78e74a2 into dev Mar 18, 2024
3 checks passed
Copy link

Successfully tore down https://msg-adamant-pr-609.surge.sh 🥲

@RealGoodProgrammer RealGoodProgrammer deleted the fix/hidden-emojies-on-chrome-ios branch March 18, 2024 17:44
@RealGoodProgrammer RealGoodProgrammer mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants