Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Health Check (UI fix) #588

Merged
merged 20 commits into from
Feb 11, 2024
Merged

Conversation

juliahermak
Copy link
Member

@juliahermak juliahermak commented Jan 20, 2024

Rename Nodes list to Nodes and services
Format the Nodes screen (screenshots in trello)
Make Settings icon on the Login screen not so bright
Allow disabling coin nodes (not to expose user IP)
Don't show Use socket connections option and Support decentralization in the Coin nodes and Services tabs.
Separate Choose the fastest nodeChoose the fastest ADM node (default disabled), Choose the fastest coin node (default enabled), Choose the fastest service node (default enabled)
Bug: When a coin node is not available, it's shown 0 height and "Green" status (Tor, screenshot)
Bug: Wrong node's version for inactive notes (screenshot)

Screenshot 2024-02-01 04 16 29

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2024 8:58am

Copy link

github-actions bot commented Jan 20, 2024

Deployed to https://msg-adamant-pr-588.surge.sh 🚀

@adamant-al
Copy link
Member

@juliahermak
I've checked https://msg-adamant-pr-588.surge.sh/
And see no changes except 'Rename Nodes list to Nodes and services'

src/components/nodes/adm/AdmNodesTableItem.vue Outdated Show resolved Hide resolved
src/components/nodes/coins/CoinNodesTableItem.vue Outdated Show resolved Hide resolved
src/store/modules/nodes/nodes-mutations.js Outdated Show resolved Hide resolved
src/store/modules/nodes/nodes-plugin.js Outdated Show resolved Hide resolved
src/store/modules/nodes/nodes-plugin.js Outdated Show resolved Hide resolved
@juliahermak
Copy link
Member Author

@adamant-al Try again because I can see all the changes.
Screenshot 2024-01-24 16 06 50

Copy link
Member

@adamant-al adamant-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make it syllable
image
  • Make the same for ADM nodes
  • Remember this part
image
  • I see Settings icon same bright
image

@bludnic
Copy link
Member

bludnic commented Jan 27, 2024

@adamant-al
Copy link
Member

adamant-al commented Jan 28, 2024

@juliahermak

Please update this part also:

Screenshot 2024-01-28 в 13 05 30
  • No line break between 213 and ms ( )
  • Make ms of text-explanation style (as node version)
  • No line break between "cube" and height
  • Format height: 3853373138,533,731. See the task for iOS as an example Feat: Change node height format https://trello.com/c/igvLgkVP

Check this style:

image

Can we move style="font-size: 12px; height: 12px; width: 12px;" to styles?

Both for ADM and coin nodes.

@juliahermak juliahermak self-assigned this Jan 30, 2024
src/components/nodes/adm/AdmNodesTableItem.vue Outdated Show resolved Hide resolved
src/store/modules/nodes/nodes-plugin.js Outdated Show resolved Hide resolved
@adamant-al
Copy link
Member

@juliahermak
Looks good, thank you.

Two more things:

  • Add "Coin" header (same style as Host and Ping)
  • Make this space smaller. Probably, remove padding-right: 8px!important; for the Coin specific column. I don't understand space between Coin and Host is wider then between Host and Ping.
image

@adamant-al adamant-al changed the title feat: ui fix feat: update Health Check (UI fix) Feb 4, 2024
src/components/nodes/components/NodeUrl.vue Outdated Show resolved Hide resolved
src/components/nodes/components/NodeUrl.vue Outdated Show resolved Hide resolved
src/components/nodes/NodesTable.vue Outdated Show resolved Hide resolved
src/components/nodes/hooks/useNodeStatus.ts Outdated Show resolved Hide resolved
src/components/nodes/hooks/useNodeStatus.ts Show resolved Hide resolved
src/components/nodes/NodesTable.vue Outdated Show resolved Hide resolved
@bludnic bludnic merged commit d05a89a into dev Feb 11, 2024
3 checks passed
@bludnic bludnic deleted the feat/health-check-improvements branch February 11, 2024 15:50
Copy link

Successfully tore down https://msg-adamant-pr-588.surge.sh 🥲

@RealGoodProgrammer RealGoodProgrammer mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants