-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESLint errors and Prettify entire codebase #566
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deployed to https://msg-adamant-pr-566.surge.sh 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary eslint-disable
comments.
Can we add this plugin? I remember you asking somebody to order imports in a pull request
https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/order.md
If you refer to the comments I added in this PR, that's ok. Comments will be removed after refactor (not in this PR). |
Yes, it's possible. I will add it. |
Actually For sorting, I checked There a files that imports Vuex store directly. Changing the imports order may break the app. I will handle this in other task. |
@bludnic What do you mean " |
@martiliones Ok. Anyway I will leave sorting imports for another task because of reasons mentioned before. |
Successfully tore down https://msg-adamant-pr-566.surge.sh 🥲 |
Better to review commit by commit. It will be hard to see what changed because of the prettier formatting.
eslint
andprettier
on lint-staged@/*
)BigInt is not defined
error in IDEcommitlint
with conventional confignpm run typecheck
scriptvite-*.config.ts
files intsconfig