-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/update bitcoinjs lib #544
Conversation
…injs-lib ^5.2.0 -> 6.1.15
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deployed to https://msg-adamant-pr-544.surge.sh 🚀 |
Co-authored-by: bludnic <victorcpla@gmail.com>
Successfully tore down https://msg-adamant-pr-544.surge.sh 🥲 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Try to send txs (including taproot) through
bitcoind
, not an indexer. See 'Expose bitcoind API' https://trello.com/c/Pa45S7nJ (currently btcnode2 only).
Probably, we can switch tobitcoind
for most requests (except tx history by address). Is it possible to optimize tx creation and don't retrieve hexes for all of unspents withbitcoind
? -
What's the reason to add two more libs?
ecpair
,tiny-secp256k1
(plus vite-plugin-wasm
andvite-plugin-top-level-await
). Why can't we usebitcoin.ECPair.fromPrivateKey()
? Doesn't 'bitcoinjs-lib' includeECPair
or alternative anymore?
Have you tested DOGE and DASH? |
The Since |
We will try. |
getAccount()
now usesecpair
andtiny-secp256k1
deps for generating bitcoin addressTrasnsactionBuilder
withPsbt
vite-plugin-wasm
andvite-plugin-top-level-await
(required bytiny-secp256k1
)Since
Psbt
requires the full transaction in HEX, additional requests toGET /tx/${id}/hex
are made.