Correct authz capabilities #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying cw-orchestrator with
|
| Latest commit: |
0847bc9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fbd99eb7.cw-orchestrator.pages.dev |
| Branch Preview URL: | https://nicolas-orc-172-authz-messag.cw-orchestrator.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
CyberHoward
reviewed
Sep 27, 2024
| @@ -380,7 +380,7 @@ pub async fn upload_wasm<T: TxSender>( | |||
| e.write_all(&file_contents)?; | |||
| let wasm_byte_code = e.finish()?; | |||
| let store_msg = cosmrs::cosmwasm::MsgStoreCode { | |||
| sender: sender.account_id(), | |||
| sender: sender.msg_sender().map_err(Into::into)?, | |||
There was a problem hiding this comment.
I don't think we need to authz for uploads
There was a problem hiding this comment.
why not ? Some chains have permissioned uploads ! (I'm thinking Stargaze from the top of my head)
There was a problem hiding this comment.
I am actually using it currently for Stargaze uploads :)
Kayanski
deleted the
nicolas/orc-172-authz-message-sender-is-the-wrong-one
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authz capabilities are wrong inside cw-orch-daemon when interacting with contracts. This PR aims to correct that
Checklist