Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocked before cw-multi-test 3.0-IBC] Replace Cw-Multi-Test wiith official version #491

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Sep 18, 2024

This PR aims at removing the dependency of our fork of cw-multi-test and moving it to the official cw-multi-test.

This is still a draft because we are waiting for cw-multi-test to stabilize version 3.0.0 (https://github.com/CosmWasm/cw-multi-test/milestone/11)

Checklist

  • Changelog updated.
  • Docs updated.

Copy link

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 576d3fc
Status: ✅  Deploy successful!
Preview URL: https://abae0af7.cw-orchestrator.pages.dev
Branch Preview URL: https://cw-multi-test-use-official.cw-orchestrator.pages.dev

View logs

@Buckram123
Copy link
Contributor

By the way, are we supposed duplicate cosmwasm set of features like cw-multi-test do?
https://github.com/CosmWasm/cw-multi-test/blob/b846f156f72e98d2037710dab856544fbb3a49db/Cargo.toml#L17-L27
Or setting latest version features on cosmwasm packages would be sufficient?

@Kayanski
Copy link
Contributor Author

By the way, are we supposed duplicate cosmwasm set of features like cw-multi-test do? https://github.com/CosmWasm/cw-multi-test/blob/b846f156f72e98d2037710dab856544fbb3a49db/Cargo.toml#L17-L27 Or setting latest version features on cosmwasm packages would be sufficient?

I'm not sure. setting the last one should be sufficient.
Note here that when execution 2.0, all the features are available by default so we don't need to bother. If a user needs the specific features, we might think of that, but definitely not right now. I haven't heard someone complain about this

@Kayanski Kayanski changed the title Replace Cw-Multi-Test wiith official version [Blocked before cw-multi-test 3.0-IBC] Replace Cw-Multi-Test wiith official version Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants