-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the tls-client README.md #229
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RonEld Can you please explain the additional changes provided with this PR? I know that the data needed for the public access have changed, so I was expecting the changes to address that, however, it is not clear from the commit, why they were introduced.
I built and ran the example and I confirm that it still works, so I approve the PR in principle. However, I think it would be better for the sake of tracking the changes to split this PR into two commits with descriptive messages.
Update the tls-client application `README.md` as it mentions EasyConnect, and it is not true anymore.
Update links to a current location.
@k-stachowiak Thank yo for your review! I have split the commit to two, per your suggestion. |
@RonEld Thank you for addressing that. I still approve the PR. |
@sbutcher-arm - please review this PR, as it is targeted for 19.02. |
Bump @sbutcher-arm @k-stachowiak , you should merge this in... |
Nothing to do with me @JanneKiiskila, nor @k-stachowiak. We don't work on this. In actual fact, I think ownership has passed hands two or three times since this PR was opened. |
Update the tls-client application
README.md
asit mentions EasyConnect, and it is not true anymore. Update the links as
well.
Fixes #228