Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-default, memory-heavy tests from the benchmark application #213

Conversation

k-stachowiak
Copy link
Contributor

@k-stachowiak k-stachowiak commented Nov 6, 2018

This PR removes memory-heavy tests from the benchmark application. They are not used by default and they don't work for all the tested devices due to the memory restrictions (at least ones implied by the build configurations).

Fixes (works around until we have resolved the memory configuration issues) #138

edit:
It apparently also fixes (works around...) #208 and #210.

@k-stachowiak
Copy link
Contributor Author

retest

@k-stachowiak k-stachowiak force-pushed the iotssl-2427-remove-memory-heavy-tests branch from 94bf327 to 608042f Compare November 6, 2018 14:37
@k-stachowiak
Copy link
Contributor Author

retest

@k-stachowiak
Copy link
Contributor Author

The only failing tests are due to a known issue: #209

#if !defined(MBEDTLS_DHM_C)
#define MBEDTLS_DHM_C
#endif

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-stachowiak: Thanks for the PR, but in my opinion this is not sufficient. I think you should explicitly use #undef if you want that particular feature to be disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andresag01 Thanks for the review.

This change was made based on the following reasoning: there are some features used here, that are not even enabled by default. Therefore, we should not enable them forcibly. Should, in the future, the features become enabled by default (and break this app), we may return to this issue, and e.g. explicitly disable them.

Looking at this from another perspective, there are probably more features in Mbed TLS that would break the benchmark, but we don't explicitly disable the in this file, since they are not enabled by default. Should DHM be treated specially in this case?

Please consider my arguments and confirm, if you think the feature should still be explicitly disabled.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@k-stachowiak
Copy link
Contributor Author

@andresag01 Do you feel satisfied by my reply to your comment? If so, can you approve the PR, or maybe you have more change requests?

@simonbutcher
Copy link
Contributor

Passes CI with the exception of the known broken tests on UBLOX.

@simonbutcher simonbutcher merged commit 6558cbf into ARMmbed:master Dec 13, 2018
@adbridge
Copy link
Contributor

@k-stachowiak @sbutcher-arm Why has this just been merged to master when the 5.11 release has not been made yet and all fixes should consequently still be going to the 5.11.0-oob branch ??!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants