-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support collection of counters with rocprofiler #12
Draft
jordap
wants to merge
8
commits into
main
Choose a base branch
from
jorda/rocprofiler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordap
force-pushed
the
jorda/rocprofiler
branch
from
March 23, 2024 14:27
d6ae126
to
342c5e3
Compare
New configuration options to enable/disable rocprofiler, as well as to configure the list of counters to sample.
jordap
force-pushed
the
jorda/rocprofiler
branch
from
July 11, 2024 17:49
342c5e3
to
07b7aa6
Compare
I updated this branch to match the most recent changes in Omnistat. Still need to manually set HSA_TOOLS_LIB to get the counters until rocprofiler is fixed (SWDEV-465681), and update the build of the pyrocprofiler module to match omnistat. |
jordap
force-pushed
the
jorda/rocprofiler
branch
from
July 11, 2024 18:57
5e78a43
to
8756554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial prototype to test the collection of hardware counters using rocprofiler's device mode.
It introduces the
pyrocprofiler
Python module to call rocprofiler using a small header-only wrapper around the API for device mode (pyrocprofiler/device_session.hpp).There is also a standalone Prometheus collector that uses the
pyrocprofiler
module that still works outside of omniwatch for initial testing.Pending tasks:
More details about rocprofiler's device mode API: https://rocm.docs.amd.com/projects/rocprofiler/en/docs-6.0.0/doxygen/docBin/html/group__device__profiling.html
I used the following example to understand how to call the device mode API: https://github.com/ROCm/rocprofiler/blob/amd-master/samples/profiler/device_profiling_sample.cpp