Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: fixed #248, adjusted region growing and surface resolution settings, new function for export selected segments as new segmentation node #255

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

RuoyanMeng
Copy link
Collaborator

@RuoyanMeng RuoyanMeng commented Sep 25, 2023

@RafaelPalomar
Copy link
Collaborator

@RuoyanMeng, could you briefly describe what are the bug and the fix?

volume_cm3 = stats[segmentId,"LabelmapSegmentStatisticsPlugin.volume_cm3"]
elif stats[segmentId,"ScalarVolumeSegmentStatisticsPlugin.voxel_count"]:
voxel_count = stats[segmentId,"ScalarVolumeSegmentStatisticsPlugin.voxel_count"]
volume_cm3 = stats[segmentId,"ScalarVolumeSegmentStatisticsPlugin.volume_cm3"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain this snippet. Why the need to have LabelMap and ScalarVolume counts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I added the selected segmentations combined node as a "vtkMRMLLabelMapVolumeNode", in some cases, it happens that the input turns into ScalarVolume data and pops up error messages about couldn't find LabelmapSegmentStatisticsPlugin. But lately, I haven't met this issue, just in case it would happen to a different dataset, I added those scripts to ensure that the function works.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Region growing setting changes because we have more than 7 labels in the original data, to avoid conflicts, adjust the base value to 100.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolution setting change is a temporary solution before I develop a stable method. For most cases, it needs at least 500*500 to ensure successful region growing for FaceConnectivity.

@RuoyanMeng RuoyanMeng marked this pull request as draft September 30, 2024 13:07
@RuoyanMeng RuoyanMeng force-pushed the feature/Resectogram-ResectionVolumetry branch from 74fc526 to 2ccac63 Compare October 3, 2024 09:05
@RuoyanMeng RuoyanMeng changed the title BUG: fixed #248, adjusted region growing and surface resolution settings ENH: fixed #248, adjusted region growing and surface resolution settings, new function for export selected segments as new segmentation node Oct 15, 2024
@RuoyanMeng RuoyanMeng marked this pull request as ready for review October 17, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants