-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: fixed #248, adjusted region growing and surface resolution settings, new function for export selected segments as new segmentation node #255
base: develop
Are you sure you want to change the base?
Conversation
…solution settings
@RuoyanMeng, could you briefly describe what are the bug and the fix? |
volume_cm3 = stats[segmentId,"LabelmapSegmentStatisticsPlugin.volume_cm3"] | ||
elif stats[segmentId,"ScalarVolumeSegmentStatisticsPlugin.voxel_count"]: | ||
voxel_count = stats[segmentId,"ScalarVolumeSegmentStatisticsPlugin.voxel_count"] | ||
volume_cm3 = stats[segmentId,"ScalarVolumeSegmentStatisticsPlugin.volume_cm3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain this snippet. Why the need to have LabelMap and ScalarVolume counts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I added the selected segmentations combined node as a "vtkMRMLLabelMapVolumeNode", in some cases, it happens that the input turns into ScalarVolume data and pops up error messages about couldn't find LabelmapSegmentStatisticsPlugin. But lately, I haven't met this issue, just in case it would happen to a different dataset, I added those scripts to ensure that the function works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Region growing setting changes because we have more than 7 labels in the original data, to avoid conflicts, adjust the base value to 100.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolution setting change is a temporary solution before I develop a stable method. For most cases, it needs at least 500*500 to ensure successful region growing for FaceConnectivity.
c01526c
to
195043f
Compare
74fc526
to
2ccac63
Compare
…onsideration of resections) into new segmentation node
#266 #248