Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file type: IBW #34

Merged
merged 71 commits into from
May 1, 2024
Merged

Add file type: IBW #34

merged 71 commits into from
May 1, 2024

Conversation

SylviaWhittle
Copy link
Collaborator

Closes #17

This PR adds IBW support

Just basic loading of .ibw files, akin to how I did .spm.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 67.62%. Comparing base (f282c31) to head (85ffb11).
Report is 74 commits behind head on main.

Files Patch % Lines
topofileformats/spm.py 63.15% 14 Missing ⚠️
topofileformats/jpk.py 80.43% 9 Missing ⚠️
topofileformats/ibw.py 78.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   65.87%   67.62%   +1.75%     
==========================================
  Files           3        6       +3     
  Lines         337      451     +114     
==========================================
+ Hits          222      305      +83     
- Misses        115      146      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work burning through these @SylviaWhittle

Some comments inline.

You'll likely encounter merge conflicts in the subsequent commits, in the README.md and possibly example_01.ipynb. They should be straight-forward to resolve though.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
topofileformats/ibw.py Outdated Show resolved Hide resolved
topofileformats/ibw.py Show resolved Hide resolved
topofileformats/ibw.py Outdated Show resolved Hide resolved
@ns-rse ns-rse mentioned this pull request Apr 24, 2024
@SylviaWhittle SylviaWhittle force-pushed the SylviaWhittle/file-type-ibw branch from f5eb9de to fcb12a9 Compare April 29, 2024 22:22
SylviaWhittle and others added 26 commits May 1, 2024 09:05
Co-authored-by: Neil Shephard <n.shephard@sheffield.ac.uk>
Co-authored-by: Neil Shephard <n.shephard@sheffield.ac.uk>
Re-writing example in docstring to use [doctest format](https://numpydoc.readthedocs.io/en/latest/format.html#examples).

Minor tpyo in README.md corrected.
…fileformats into SylviaWhittle/file-type-ibw
Copy link
Collaborator

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't understand why all the other changes have appeared on this branch, particularly as they are already on main.

One tiny suggestion for the disabled pylint to make it easier for readers to know what has been disabled otherwise ready to go.

topofileformats/asd.py Outdated Show resolved Hide resolved
@SylviaWhittle SylviaWhittle merged commit 4eafdff into main May 1, 2024
10 checks passed
@ns-rse ns-rse deleted the SylviaWhittle/file-type-ibw branch May 2, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate .ibw support from TopoStats
3 participants