Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mom5: new switch --no_version is required #51

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

harshula
Copy link
Collaborator

@harshula harshula commented Nov 6, 2023

The MOM5 commit d7ba13a3f364ce130b6ad0ba813f01832cada7a2 requires the --no_version switch to avoid git hashes being embedded in the binary.

@harshula harshula self-assigned this Nov 6, 2023
@harshula harshula marked this pull request as draft November 6, 2023 02:08
* The MOM5 commit d7ba13a3f364ce130b6ad0ba813f01832cada7a2
requires the --no_version switch to avoid git hashes being
embedded in the binary.
@harshula harshula force-pushed the bugfix-no_version_required branch from cb10821 to cf97c55 Compare November 6, 2023 02:09
@harshula harshula marked this pull request as ready for review November 6, 2023 02:11
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshula harshula merged commit 1123df9 into main Nov 6, 2023
1 check failed
@harshula harshula deleted the bugfix-no_version_required branch November 6, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants